-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prysmctl: Add support for writing signed validator exits to disk #12262
Conversation
@@ -230,6 +230,12 @@ var ( | |||
Name: "force-exit", | |||
Usage: "Exit without displaying the confirmation prompt", | |||
} | |||
VoluntaryExitJSONOutputPath = &cli.StringFlag{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to add this to the usage.go file I believe otherwise it won't show up in help
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It only applies to subcommands in prysmctl and validator. I put this flag everywhere that ForceExit appears
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM i didn't see anything that stood out.
What type of PR is this?
Other
What does this PR do? Why is it needed?
Adds support for saving validator exits as a JSON file.
This is intended to be used with lido ejector in messages mode
Which issues(s) does this PR fix?
Other notes for review